From dea3ff6ed2af2fe3ab084733d3e71daf4dcfb8a0 Mon Sep 17 00:00:00 2001 From: Ian Campbell Date: Sun, 21 Dec 2014 11:18:53 +0000 Subject: [PATCH] xen: arm: correct off-by-one error in consider_modules By iterating up to <= mi->nr_mods we are running off the end of the boot modules, but more importantly it causes us to then skip the first FDT reserved region, meaning we might clobber it. Signed-off-by: Ian Campbell Reviewed-by: Julien Grall --- xen/arch/arm/setup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 3991d64cc0..f49569d02b 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -286,7 +286,7 @@ static paddr_t __init consider_modules(paddr_t s, paddr_t e, return 0; /* First check the boot modules */ - for ( i = first_mod; i <= mi->nr_mods; i++ ) + for ( i = first_mod; i < mi->nr_mods; i++ ) { paddr_t mod_s = mi->module[i].start; paddr_t mod_e = mod_s + mi->module[i].size; -- 2.30.2